Use struct for JSON instead string, tests

utils/http/helpers/helpers.go

@@ -9,7 +9,6 @@ import (
 	"os"
 	"regexp"
 	"runtime"
-	"strconv"
 	"strings"
 	"time"
 
@@ -151,8 +150,23 @@ func RespondAsBadRequest(w http.ResponseWriter, r *http.Request, err error) {
 		log.Printf("%s\n", err.Error())
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusBadRequest)
-		if _, e := w.Write([]byte(`{"error":` + strconv.Quote(err.Error()) + `}`)); e != nil {
-			log.Printf("%s\n", e.Error())
+
+		type respRoot struct {
+			Error string `json:"error"`
+		}
+
+		resp := respRoot{
+			Error: err.Error(),
+		}
+
+		j, err := json.Marshal(resp)
+		if err != nil {
+			log.Printf("%s\n", err.Error())
+			return
+		}
+
+		if _, err := w.Write(j); err != nil {
+			log.Printf("%s\n", err.Error())
 		}
 	} else {
 		w.WriteHeader(http.StatusBadRequest)

utils/http/helpers/helpers_test.go

@@ -1,6 +1,7 @@
 package helpers_test
 
 import (
+	"fmt"
 	"io"
 	"net/http"
 	"net/http/httptest"
@@ -267,6 +268,36 @@ var _ = Describe("helpers", func() {
 				Expect(string(body)).To(Equal("MyContent"))
 			})
 		})
+
+		Context("RespondAsBadRequest", func() {
+			BeforeEach(func() {
+				var getTestHandler = func() http.HandlerFunc {
+					return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+						helpers.RespondAsBadRequest(w, r, fmt.Errorf("MyError"))
+					})
+				}
+
+				srv = httptest.NewServer(getTestHandler())
+				client = srv.Client()
+				resp, err = client.Get(srv.URL + "/")
+				Expect(err).To(Succeed())
+			})
+
+			AfterEach(func() {
+				Expect(resp.Body.Close()).To(Succeed())
+				srv.Close()
+			})
+
+			It("handle bad request", func() {
+				Expect(resp.StatusCode).To(Equal(http.StatusBadRequest))
+				Expect(resp.Header.Get("Content-Type")).To(Equal("application/json"))
+
+				body, err := io.ReadAll(resp.Body)
+				Expect(err).To(Succeed())
+
+				Expect(string(body)).To(MatchRegexp(`{"error":"MyError"}`))
+			})
+		})
 	})
 
 	Context("MinifyHtmlCode", func() {